Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AbstractProvider.getUserInfoFromTokens return type #1287

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Improve AbstractProvider.getUserInfoFromTokens return type #1287

merged 3 commits into from
Aug 22, 2024

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Aug 22, 2024 •
edited
Loading

Issue

The return type of the method getUserInfoFromTokens is any whereas we have its type.

Solution and steps

  • Make getUserInfoFromTokens return the generic type UserInfo

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Aug 22, 2024
Open
14 tasks
@LoicPoullain LoicPoullain merged commit e1941d1 into v5-0-0 Aug 22, 2024
2 checks passed
@LoicPoullain LoicPoullain deleted the abstract-provider-type branch August 22, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v5
Projects
Issue tracking
Status: Done / Closed This Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LoicPoullain