Update use of Flux._isactive in DropBlock to prevent deprecation warning
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darsnack
approved these changes
Oct 16, 2023
|
Done! |
darsnack
approved these changes
Oct 16, 2023
|
Should I go ahead and tag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of moving Dropout to NNlib, some of these functions were changed upstream. While this is obviously not ideal for Metalhead to use internal Flux functions, this is a temporary fix to prevent a deprecation warning from being printed every time the layer is used. Maybe later Flux can find a way to do this upstream that allows other libraries to extend.
cc @ToucheSir @darsnack to check if this is the way to go for now.