-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hook new weights #235
hook new weights #235
Conversation
One issue I missed in the last PR is the use of the |
will do, although we should avoid changing files once they are used in a tagged release. Updated weights should become a new hosted file and artifact. |
ok this is it for this PR, I'm sorry it got pretty big. I'll fix the residual problems in more focused PRs. After merging this:
|
Based on the test error, does the ResNeXt-101-64x4d SHA need to be updated? |
turns out resnext_64x4 has only the IMAGENET1K_V1 weights |
greenlights! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
also made some doc changes:
docs/make.jl
copies the readme toindex.md
so that the two don't fall out of syncFix #234, fix #206, fix #220, partially address #187