Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook new weights #235

Merged
merged 10 commits into from
May 10, 2023
Merged

hook new weights #235

merged 10 commits into from
May 10, 2023

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented May 7, 2023

also made some doc changes:

  • fixed the links in the readme
  • added to the readme table some missing model
  • now docs/make.jl copies the readme to index.md so that the two don't fall out of sync

Fix #234, fix #206, fix #220, partially address #187

@darsnack
Copy link
Member

darsnack commented May 7, 2023

One issue I missed in the last PR is the use of the main branch URL from HF. These should be updated to reflect a specific commit so that each release's artifacts continue to work as HF is updated.

@CarloLucibello
Copy link
Member Author

One issue I missed in the last PR is the use of the main branch URL from HF. These should be updated to reflect a specific commit so that each release's artifacts continue to work as HF is updated.

will do, although we should avoid changing files once they are used in a tagged release. Updated weights should become a new hosted file and artifact.

@CarloLucibello
Copy link
Member Author

CarloLucibello commented May 7, 2023

ok this is it for this PR, I'm sorry it got pretty big. I'll fix the residual problems in more focused PRs.

After merging this:

  • for every model for which we had pretrained weights in the last tagged release we will continue to have pretrained weights, either in the old "save the whole model" format (squeezenet, densenet) or the new "save only the state" format
  • we also have weights for the ViT, although the output has some slight discrepancies with pytorch

@darsnack
Copy link
Member

darsnack commented May 8, 2023

Based on the test error, does the ResNeXt-101-64x4d SHA need to be updated?

@CarloLucibello
Copy link
Member Author

turns out resnext_64x4 has only the IMAGENET1K_V1 weights

@CarloLucibello
Copy link
Member Author

greenlights!

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@CarloLucibello CarloLucibello merged commit b8d616c into master May 10, 2023
@CarloLucibello CarloLucibello deleted the cl/dev3 branch July 17, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants