-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: [utils-testing] Import Jest hooks from runner instead of globals #574
base: main
Are you sure you want to change the base?
Conversation
This PR changes where we import the Jest hooks from so the testing library can be used during Jest global setup and teardown.
1f6bf12
to
73e7d7b
Compare
WalkthroughThis update modifies the import statements for Jest testing hooks to replace Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant TestHooks
participant Tests
TestRunner->>TestHooks: Load Hooks (beforeEach, afterEach)
TestHooks->>Tests: Execute Tests
Tests->>TestHooks: Report Results
TestHooks->>TestRunner: Return Results
Recent review detailsConfiguration used: CodeRabbit UI Files ignored due to path filters (2)
Files selected for processing (2)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
This PR changes where we import the Jest hooks from so the testing library can be used during Jest global setup and teardown.
Jest will currently raise an error if you attempt to use the library in the setup/teardown files due to how hooks are elevate to the global namespace. This change makes the library compatible with both Jest and non-Jest environments.