pimd: MSDP per peer SA limit #17521
Open
pimd: MSDP per peer SA limit #17521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MSDP shutdown and SA limiting configuration to YANG model. (no implementation, just boiler plate code) Signed-off-by: Rafael Zalamena <[email protected]>
donaldsharp
reviewed
Nov 26, 2024
pimd/pim_msdp.h
Outdated
| @@ -152,6 +152,9 @@ struct pim_msdp_peer { | |||
| char *acl_in; | |||
| /** SA output access list name. */ | |||
| char *acl_out; | |||
|
|
|||
| /** SA maximum amount. */ | |||
| size_t sa_limit; | |||
There was a problem hiding this comment.
since the limit is 4billion why not a uint32_t?
rzalamena
force-pushed
the
msdp-sa-limit
branch
from
18f3616
to
de55848
Compare
Implement a command to enable/disable per peer MSDP SA limiting. Signed-off-by: Rafael Zalamena <[email protected]>
Test that only the limit amount of SAs is learned from the peer. Signed-off-by: Rafael Zalamena <[email protected]>
Let user know about the new MSDP SA limit command. Signed-off-by: Rafael Zalamena <[email protected]>
rzalamena
force-pushed
the
msdp-sa-limit
branch
from
de55848
to
cf12345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSDP feature to help limit the amount of SAs a peer can learn. This is useful to keep the amount of SAs to a certain amount or to handle misconfigured peers.