bgpd: fix for the validity and the presence of prefixes in the BGP VPN table. #17370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-6wind
force-pushed
the
fix-vpn-leaking
branch
from
106e889
to
fdd3c21
Compare
louis-6wind
force-pushed
the
fix-vpn-leaking
branch
from
fdd3c21
to
ad5959e
Compare
louis-6wind
force-pushed
the
fix-vpn-leaking
branch
from
ad5959e
to
0a4f3e1
Compare
louis-6wind
force-pushed
the
fix-vpn-leaking
branch
2 times, most recently
from
b4c2e9b
to
dc3a481
Compare
|
ci:rerun |
1 similar comment
|
ci:rerun |
ton31337
reviewed
Nov 26, 2024
bgpd/bgp_mplsvpn.c
Outdated
|
|
||
| if (attrhash_cmp(bpi->attr, new_attr) && labelssame && | ||
| !CHECK_FLAG(bpi->flags, BGP_PATH_REMOVED) && | ||
| !!leak_update_nexthop_valid(to_bgp, bn, new_attr, afi, safi, source_bpi, bpi, |
There was a problem hiding this comment.
nit: leak_update_nexthop_valid() is already bool, no need for !!.
|
ci:rerun |
They are the same value. Signed-off-by: Louis Scalbert <[email protected]>
Mark a nexthop as invalid if the origin VRF is unusable, either because it does not exist or its interface is down. Signed-off-by: Louis Scalbert <[email protected]>
When leak_update() rechecks an existing path, it considers nothing to update if the attributes and labels are not changed. However, it does not take into account the nexthop validity. Perform a leak update if the nexthop validity has changed. Signed-off-by: Louis Scalbert <[email protected]>
Do not leak if origin vrf is not usable Signed-off-by: Louis Scalbert <[email protected]>
Update route_leak_basic tests. The routes with an unusable nexthop VRF are no more present in the RIB. Signed-off-by: Louis Scalbert <[email protected]>
The bgp_bmp test is failing because r2 lacks the vrf1 VRF, which prevents it from exporting VPN prefixes from the configured vrf1 BGP instance. Previous versions allowed the export of static BGP prefixes from a non-existent VRF, so the test passed under those conditions. Add a vrf1 VRF on r2. Fixes: d748544 ("topotests: add basic bgp bmp test") Signed-off-by: Louis Scalbert <[email protected]>
Check bgp vpn table in bgp_vpnv4_route_leak_basic Signed-off-by: Louis Scalbert <[email protected]>
In bgp_vpnv4_route_leak_basic, remove and add back the static prefix 172.16.3.0/24 on VRF DONNA. Before the previous fixes, the 172.16.3.0/24 prefix re-appeared when it was added back in the VPN table but it was marked as invalid. Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
fix-vpn-leaking
branch
from
dc3a481
to
c821483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the validity and the presence of prefixes in the BGP VPN table.
See individial commit logs