isisd: Command "show isis interface IFNAME json" displays all interfaces's circuit id. #17158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baozhen-H3C
force-pushed
the
202410180184
branch
from
ffff0b1
to
0af4c91
Compare
baozhen-H3C
force-pushed
the
202410180184
branch
5 times, most recently
from
cf57446
to
4430811
Compare
ton31337
reviewed
Oct 18, 2024
mjstapp
reviewed
Oct 18, 2024
| @@ -955,6 +955,8 @@ void isis_circuit_print_json(struct isis_circuit *circuit, | |||
| char buf_prx[INET6_BUFSIZ]; | |||
| char buf[255]; | |||
|
|
|||
| json_object_int_add(json, "circuit", circuit->circuit_id); | |||
There was a problem hiding this comment.
why add this value a second time, with a new key - isn't it being added just below with "circuit-id"?
There was a problem hiding this comment.
I want to print the circuit_id only when printing a specific interface, if this modification is allowed.
baozhen-H3C
force-pushed
the
202410180184
branch
2 times, most recently
from
09dc643
to
0a845f7
Compare
|
@baozhen-H3C please put the description in the commit, not in the PR's description. |
|
So, is this change only to skip showing circuits that do not have any interfaces assigned? |
|
@ton31337 Yes, it now seems unnecessary.Perhaps what I'm doing is pointless. |
baozhen-H3C
force-pushed
the
202410180184
branch
from
0a845f7
to
ed2dfdf
Compare
TBH, this is kinda of a breaking change (at some level). |
riw777
reviewed
Oct 22, 2024
baozhen-H3C
force-pushed
the
202410180184
branch
from
6f7b7ce
to
8a67c5f
Compare
… ID of all interfaces
1.before the commit
if the interface exists:
sonic# show isis interface lo json
{
"areas":[
{
"area":"10",
"circuits":[
{
"circuit":13
},
{
"circuit":14
},
{
"circuit":0,
"interface":{
"name":"lo",
"state":"Up",
"is-passive":"passive",
"circuit-id":"0x0",
"type":"loopback",
"level":"L1",
"levels":[
{
"level":"L1",
"metric":10
}
],
"ip-prefix":{
"ip":"7.7.7.7/32"
}
}
}
]
}
]
}
if the interface doesn't exist:
sonic# show isis interface abc json
{
"areas":[
{
"area":"10",
"circuits":[
{
"circuit":13
},
{
"circuit":14
},
{
"circuit":0
}
]
}
]
}
2.after the commit
if the interface exists:
sonic# show isis interface lo json
{
"areas":[
{
"area":"10",
"circuits":[
{
"circuit":0,
"interface":{
"name":"lo",
"state":"Up",
"is-passive":"passive",
"circuit-id":"0x0",
"type":"loopback",
"level":"L1",
"levels":[
{
"level":"L1",
"metric":10
}
],
"ip-prefix":{
"ip":"7.7.7.7/32"
}
}
}
]
}
]
}
if the interface doesn't exist:
sonic# show isis interface abc json
{
"areas":[
{
"area":"10",
"circuits":[
]
}
]
}
Signed-off-by: baozhen-H3C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is only to skip showing circuits that do not have any interfaces assigned.