Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3277] Dynamically changing the timeout for Reconnect #3275

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

GodFuper
Copy link
Contributor

I suggest making the dynamic connection timeout depends on whether you are currently in the game.

During the game, you need to try to reconnect a little faster. It has a positive effect on reconnect in ICE and in the game itself.

@Sheikah45
Copy link
Member

My main concern here is that I am not sure how much effect the timeout has on the reconnect speed. And if the shorter time might make it harder for some players to reconnect as it constantly timesout

@GodFuper
Copy link
Contributor Author

Link #3277

@GodFuper GodFuper changed the title Dynamically changing the timeout for Reconnect [3277] Dynamically changing the timeout for Reconnect Nov 24, 2024
@Brutus5000
Copy link
Member

Brutus5000 commented Nov 25, 2024

Given that we already call fafServerAccessor.setPingIntervalSeconds(5); I think it makes sense to also decrease the timeout time.

Also long-term speaking this is the wrong solution. The correct solution is to extract the ICE signaling out of the lobby server and do it in the icebreaker

@Sheikah45 Sheikah45 merged commit df2a393 into FAForever:develop Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants