Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay show game time #3233

Merged

Conversation

sulikdan
Copy link
Contributor

@sulikdan sulikdan commented Aug 16, 2024

Solves issue 3159 (Hope I got it right, extremely hungry, gonna get somethign ..) - #3233

Added 2 new icons:

  • game-duration
  • world(real)-duration

both now showing in:

  • card_replay
  • replay_detail

game-duration is being shown in card-replay.

@Sheikah45
Any thoughts and prayers?

Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Could we add a test to make sure tick duration shows/doesn't show appropriately

@sulikdan
Copy link
Contributor Author

@Sheikah45 updated tests. Current implementation shows bot real-time and game-time, therefore not much of modification.

Slightly increased size of card, as there was issue that new values(with icons) were only partially visible, though there are still occur situation that second may be cut out.(Check local replay) I'm not sure how to address this, or even if there should be done anythign against that as it is not really significant - for clear data the user shall open the card itself ...

@Sheikah45 Sheikah45 force-pushed the feature/3159-replay-game-time-display branch from 99b3578 to 729edcc Compare August 17, 2024 20:00
@Sheikah45 Sheikah45 enabled auto-merge (squash) August 17, 2024 20:00
@Sheikah45 Sheikah45 merged commit 817f67b into FAForever:develop Aug 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants