Restore UnitDB function - Update and improve displayed data #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved error handling. Detect when commands fail. Exit script on failure. Removed use of shell_exec (it does not detect command failures).
Correct script errors related to differences between PHP 8.x and earlier versions. Example: count() generates an error if the argument is not an array object (string being passed). Previously, a string argument would return a 1. Correct update.php to read in blueprint data in the correct order (3599 files serve as a baseline, and must be read first). Improved error handling. Add code to properly handle reformatted blueprints. Overhaul of unit DPS and fire cycle calculations to improve accuracy. General improvements in accuracy and completeness of unit data.
… into 2024-Repair-Update
Brutus5000
requested changes
Apr 5, 2024
Requested changes of 2024-04-05 (code cleanup). Corrected DPS code for Salvation.
Updated comment per request.
Brutus5000
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct script errors related to differences between PHP 8.x and earlier versions.
Example:
count() generates an error if the argument is not an array object (string being passed). Previously, a string argument would return a 1.
Correct update.php to read in blueprint data in the correct order (3599 files serve as a baseline, and must be read first).
Improved error handling.
Add code to properly handle reformatted blueprints.
Overhaul of unit DPS and fire cycle calculations to improve accuracy.
General improvements in accuracy and completeness of unit data.
Displaying of Missile cost (nukes, tacticals) restored.
All code for calculating missile/projectile counts was re-written to improve accuracy. Moved all such code to calculateFireCycle, to eliminate duplication.
Added filter to prevent units that don't have a 'faction' from causing the script to fail.