Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdditt2000
What issues does this address?
What does this change do?
The schema already had a
customOpts
array to specify custom options. This change enables this array for the Azure Log Analytics consumer. When amanagementUrl
oropinsightsUrl
custom option is detected, that URL is used instead of attempting to calculate the URL from the region/identity.Because there was a small schema change, that necessitated a bump to the schema version number
Where should the reviewer start?
The unit tests and comments in the code/docs demonstrate how to use these new options. You could setup a consumer with a configuration of
region: 'USEast'
(public cloud) but specify USGov URLs in customOpts and verify that the consumer is using the specific us gov values.Any background context?
As the issue points out, it will not be possible to construct every URL based on information present on the VM at this time. For some clouds whose URLs can not be publicly published, the user will just have to specify the URL to use.