Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for azure urls #216

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

blheatwole
Copy link

@blheatwole blheatwole commented Aug 17, 2022

@mdditt2000

What issues does this address?

What does this change do?

The schema already had a customOpts array to specify custom options. This change enables this array for the Azure Log Analytics consumer. When a managementUrl or opinsightsUrl custom option is detected, that URL is used instead of attempting to calculate the URL from the region/identity.

Because there was a small schema change, that necessitated a bump to the schema version number

Where should the reviewer start?

The unit tests and comments in the code/docs demonstrate how to use these new options. You could setup a consumer with a configuration of region: 'USEast' (public cloud) but specify USGov URLs in customOpts and verify that the consumer is using the specific us gov values.

Any background context?

As the issue points out, it will not be possible to construct every URL based on information present on the VM at this time. For some clouds whose URLs can not be publicly published, the user will just have to specify the URL to use.

@blheatwole
Copy link
Author

We are currently using a custom build of the telemetry-streaming app which includes this PR, and it is working well.

@elias-p
Copy link

elias-p commented Feb 9, 2023

any update about this issue, I have a similar need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry Fails on Azure Clouds Other Than AzurePublic and AzureUSGovernment
2 participants