feat: TypeScript types file [#319] #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nooras can you please add replication steps to tell us how you tested to ensure these are working properly? Thanks! |
|
Hey @gavinr-maps |
gavinr-maps
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks for the PR!
Can you also please add the index.d.ts file to the files array in the package.json per here:
- Property 'Vector' does not exist on type 'typeof esri' esri-leaflet-vector#154 (comment)
- Add index.d.ts to release esri-leaflet-vector#167
Also I think you need to include the providers, from here: https://developers.arcgis.com/esri-leaflet/api-reference/controls/geosearch/#providers
Closed
|
hey @gavinr-maps |
|
works for me! @hhkaos can you please test? |
gavinr-maps
approved these changes
Oct 23, 2024
hhkaos
approved these changes
Oct 24, 2024
|
Great job @nooras. Thanks! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TypeScript types file
Fix: #319
@gavinr-maps
Kindle please review the PR.