Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GTK and GTK-layer-shell to latest versions #104

Closed
wants to merge 5 commits into from

Conversation

Ferdi265
Copy link
Contributor

This PR updates the GTK3 libraries to the latest versions, in preparation for the port to GTK4. This PR applies on top of #103.

The main changes are:

  • use async_channel instead of the GTK MainContext::channel(), which has been removed
  • slight changes in the GTK control flow enum (Break instead of Continue(false), I hope I understood this correctly)
  • slight changes in the GTK-layer-shell API (trait methods on window instead of free functions)

@Ferdi265 Ferdi265 mentioned this pull request Sep 15, 2024
3 tasks
@Ferdi265
Copy link
Contributor Author

The async-channel fixes are incorrect; something breaks as soon as a notification from swayosd-client comes in, somehow closing the channel used for the libinput backend, which makes caps lock notifications fail. Will debug and fix this in the coming days.

@Ferdi265
Copy link
Contributor Author

The async-channel fixes are incorrect; something breaks as soon as a notification from swayosd-client comes in, somehow closing the channel used for the libinput backend, which makes caps lock notifications fail. Will debug and fix this in the coming days.

fixed in latest push. Apparently we can't return from the closure we use the channel in, otherwise it gets closed somehow. Replacing return Continue(true) with continue works.

@ErikReider
Copy link
Owner

Updated to GTK4, so this isn't necessary anymore, thanks anyway!!! :D

@ErikReider ErikReider closed this Nov 19, 2024
@Ferdi265 Ferdi265 deleted the update-gtk branch November 21, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants