Add basic TLS common tests #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start a cluster with TLS and verify that ered can communicate with the cluster, and verify the behavior when using an expired client certificate. Some tests require the tool `faketime` to modify the system time, but tests are skipped if the tool is not available in PATH. https://manpages.ubuntu.com/manpages/trusty/man1/faketime.1.html
zuiderkwast
reviewed
Nov 18, 2024
zuiderkwast
approved these changes
Nov 18, 2024
| end. | ||
|
|
||
| generate_tls_certs() -> | ||
| filelib:ensure_path("tls/"), |
There was a problem hiding this comment.
This requires that the current directory is something specific? At least, the test needs write permissions in the current directory to create the tls directory and the certs.
The test doesn't delete the certs afterwards, right? Will openssl overwrite the files if we run the test again?
There was a problem hiding this comment.
When using rebar3, as we do in CI and probably most users, the current directory path is set by the common test runner.
The tls files are placed like:
<ered repo>/_build/test/logs/[email protected]_15.42.48/tls/client.crt
These files are not overwritten since rebar3 creates a new directory for each run, which might be good when reproducing an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start a cluster with TLS and verify that ered can communicate with the cluster,
and verify the behavior when using an expired client certificate.
Some tests require the tool faketime to modify the system time,
but tests are skipped if the tool is not available in PATH.