Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle and log errors when ingesting bioschemas content #936

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

fbacall
Copy link
Member

@fbacall fbacall commented Mar 11, 2024

Summary of changes

  • Catches and logs exceptions that occur when scraping Bioschemas sources.
  • Fixes awkward formatting of error messages when markdown is rendered.

Motivation and context

A user was trying to test a Bioschemas source, and a single page with a JSON error caused the entire ingestion to fail with a generic error message.

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

@fbacall fbacall merged commit 08b87e5 into master Mar 19, 2024
11 checks passed
@fbacall fbacall deleted the bioschemas-exception-handling branch March 19, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant