Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bootstrap-tab-history to pop tab switches onto history #878

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

DaanVanVugt
Copy link
Contributor

Summary of changes

  • Automatically switch to anchored tags on load
  • Push tab switches onto history

Motivation and context

I'd like to be able to deeplink to the calendar / map views

Note that we'd need to update that tab since it only loads the calendar once we click (and I expect the map to behave the same?)

Screenshots

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

Copy link
Member

@fbacall fbacall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still avoid #671 ?

We used to have a tab memory feature but it did not behave well with turbolinks

@DaanVanVugt
Copy link
Contributor Author

This should add to the history set, so I don't think it would cause that problem.

I checked just now, but the search page does not use the tab helper so has no memory.

Copy link
Member

@fbacall fbacall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@fbacall fbacall merged commit 2f4861c into ElixirTeSS:master Aug 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants