Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external resources to be replaced #1031

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

fbacall
Copy link
Member

@fbacall fbacall commented Oct 10, 2024

Summary of changes

  • Adds a setter similar to external_resources_attributes= except it removes any redundant external resources.
  • When harvesting Bioschemas mentions, they use the above setter.

Motivation and context

Fixes #1029

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

@fbacall fbacall merged commit 5d14f23 into master Oct 11, 2024
11 checks passed
@fbacall fbacall deleted the replace-external-resources branch October 11, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ingestion process possibly not removing old mentions?
1 participant