Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #186 token as request param is deprecated #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: #186 token as request param is deprecated #245

wants to merge 1 commit into from

Commits on May 5, 2023

  1. fix: Ecwid#186 token as request param is deprecated 

    Consul now warns aggressively when token is provided as a request param
and the X-Consul-Token is required. Also as already mentioned in Ecwid#186
token request param will be removed in Consul v1.17.

By reading the code and related PRs I've seen that in the so called
"new http architecture" this is addressed although not all clients fully
utilize the new Request class.

This PR uses the Request class for both Catalog and KV clients.

Should address both Ecwid#186 and Ecwid#237.
    Aggelos Karalias committed May 5, 2023
    Configuration menu
    Copy the full SHA
    e33fc46 View commit details
    Browse the repository at this point in the history