Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding CORDEX facets #2220

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

larsbuntemeyer
Copy link

@larsbuntemeyer larsbuntemeyer commented Oct 6, 2023

Description

closes #2221

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2220 (3aae9ff) into main (469fd09) will not change coverage.
Report is 15 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2220   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         238      238           
  Lines       12818    12818           
=======================================
  Hits        11956    11956           
  Misses        862      862           
Files Coverage Δ
esmvalcore/esgf/facets.py 100.00% <ø> (ø)

@bouweandela
Copy link
Member

To get these CORDEX related projects to work with the complete tool (i.e. use them in recipes), not just the esmvalcore.esgf module used for finding files and downloading them, you will probably want to add entries to the file esmvalcore/config-developer.yml, similar to the current CORDEX entry:

CORDEX:
input_dir:
default: '/'
spec: '{domain}/{institute}/{driver}/{exp}/{ensemble}/{institute}-{dataset}/{rcm_version}/{mip}/{short_name}'
BADC: '{domain}/{institute}/{driver}/{exp}/{ensemble}/{institute}-{dataset}/{rcm_version}/{mip}/{short_name}/{version}'
DKRZ: '{domain}/{institute}/{driver}/{exp}/{ensemble}/{institute}-{dataset}/{rcm_version}/{mip}/{short_name}/{version}'
ESGF: '{project.lower}/output/{domain}/{institute}/{driver}/{exp}/{ensemble}/{dataset}/{rcm_version}/{frequency}/{short_name}/{version}'
SYNDA: '{domain}/{institute}/{driver}/{exp}/{ensemble}/{dataset}/{rcm_version}/{frequency}/{short_name}/{version}'
input_file: '{short_name}_{domain}_{driver}_{exp}_{ensemble}_{institute}-{dataset}_{rcm_version}_{mip}*.nc'
output_file: '{project}_{institute}_{dataset}_{rcm_version}_{driver}_{domain}_{mip}_{exp}_{ensemble}_{short_name}'
cmor_type: 'CMIP5'
cmor_path: 'cordex'

@larsbuntemeyer
Copy link
Author

@bouweandela thanks for that! Sorry, i have been a bit lazy on this one, i'll still have to finish testing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESGF facets for CORDEX-Adjust, CORDEX-ESD, CORDEX-Reklies
2 participants