-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodules to ones that are based on cesm3_0_alpha04a #2853
Update submodules to ones that are based on cesm3_0_alpha04a #2853
Conversation
…requires PIO and NetCDF as a result
…ated beyond it as needed by PF UNIT testing, and ccs_config just updated to one beyond the previous one used by CTSM
…cesm30b04submodules
…nd share forward, and remove mct
@billsacks and @jedwards4b could you review this for the cmake changes I made for the PF unit testing? I learned more about cmake as a result of getting this to work, but I'd like to have it reviewed by the two of you with more knowledge/skill in using cmake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the lines in CMakeLists.txt that you have commented out, but otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this working @ekluzek! A couple of questions here....
OK, my suspicion about LILAC was correct, running the LILAC test I get a fail:
|
… what's going on based on code review
I've fixed the LILAC problem between a minor update, and something I need to add to cime: Now, I'm wondering what will happen with run_neon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your explanations to my questions, @ekluzek ! I'm satisfied with this now.
Hi Erik, I found that the configure script was not included in the mpi-serial distribution, I have added it in ESMCI/mpi-serial#30. I think that this will allow you to update to the latest tags. |
Excellent, thanks @jedwards4b! Yeah, that is one of the things I saw, I thought it might be generated as part of the build process. But, obviously not. Thanks for figuring that out. I"ll try with that branch and make sure it works. |
I'm rerunning all of the tests that failed with the new branch. But, a few of them have built and pass now with the mpi-serial update. So it's looking good so far. |
The mpi-serial update gets more mpi-serial tests to pass the following 17: ERS_D_Ld7_Mmpi-serial.1x1_smallvilleIA.IHistClm50BgcCropRs.izumi_intel.clm-decStart1851_noinitial While the following 8 are failing: ERS_D_Ld5_Mmpi-serial.1x1_vancouverCAN.I1PtClm50SpRs.izumi_nag.clm-CLM1PTStartDate (NLCOMP RUN) There's both DEBUG and production tests in both lists, as well as iintel and gnu compilers in both as well as both combinations of compiler and DEBUG or production for both of those as well. The nag compiler fails consistently though, and we only do nag with DEBUG on. The fails have to do with using the shared NetCDF library as so...
|
Jim provided an update to mpi-serial that fixes some of this. We also found that Izumi has some nodes with different versions of autoconf so I've opened a ticket to straighten that out. There's also a change to ccs_config that needs to come in as well. |
…sm30b04submodules
…sm30b04submodules
…r compsets, make sure yearly ER tests have at least 3 years, or done in days
…sm30b04submodules
This reverts commit d36049e.
Some of the ctsm_sci tests with Sp were running nofire, which should have been nofireemis with the default testmod.
I put in 36 year tests rather than 3 years. One ERP test I made for 762 days rather than 3 years to shorten it. 762 allows even months for one year being a leap year.
OK, good news. The aux_clm testing passes as expected on both Izumi and Derecho, and the ctsm_sci test on Derecho similarily. |
…th days so that they won't be on an exact year/month boundary
Description of changes
Update the submodules to something close to cesm3_0_alpha04a. I needed to update cime and ccs_config beyond to get the PF Unit testing working.
Specific notes
Remove mct from submodules
Add mpi-serial to submodules
Update the PF unit testing to use the full ESMF library (which will enable wider testing), this also required bringing in NetCDF and PIO libraries which we shouldn't actively use but may allow us to do fewer stub modules for I/O.
Contributors other than yourself, if any: @jedwards4b
CTSM Issues Fixed (include github issue #):
Fixes #2640
Fixes #2375
Fixes #2654
Fixes #2871
Finishes resolving #2294
Are answers expected to change (and if so in what way)?
I'm actually not sure yet, I think possibly compsets with active CISM might
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No No
Testing performed, if any: will do regular and ctsm_sci
So far done PF UNIT testing and testing of two simple cases
I haven't tested this for LILIC and I wonder if it will fail