Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team UI🖌️ #125

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Team UI🖌️ #125

wants to merge 22 commits into from

Conversation

TreavVasu
Copy link
Collaborator

@TreavVasu TreavVasu commented Mar 7, 2021

Fixes #67

Description

Include a summary of the change and relevant motivation/context.

Type of Change: (Delete irrelevant options)

  • Code
  • Testing
  • User Interface
  • Documentation

Code/Quality Assurance Only (Delete irrelevant options)

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • I have added one/more required dependencies
  • I have formatted the code using dart format (dartfmt)

Code/Quality Assurance

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Mention the dependencies/packages/plugins that have been added (if any)

@TreavVasu TreavVasu marked this pull request as draft March 7, 2021 14:30
@TreavVasu
Copy link
Collaborator Author

I Will finish it after receiving assets from designer.

@TreavVasu TreavVasu marked this pull request as ready for review March 12, 2021 13:53
Widget Reuse
Pubspec.lock revert
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Reduce the height of bottom nav bar (make it same as in home screen)
  2. Remove empty tab sections (eg: others). Refer how I implemented the logic in sponsor screen.
  3. Is multiline title name for tab not working?
  4. add letterSpacing: -0.5 to the style of text in RotatedCurvedTile (also, correct the name of the file)
  5. Add bottom padding to prevent tab being hidden.
  6. Reduce height of team card.

@TreavVasu
Copy link
Collaborator Author

TreavVasu commented Mar 14, 2021

Latest UI changes as per designer. @werainkhatri let's get this merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AboutUs - Team Screen -> UI
2 participants