Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump doctrine/lexer from 2.1.1 to 3.0.1 #6271

Open
wants to merge 3 commits into
base: 4.3
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2024

Bumps doctrine/lexer from 2.1.1 to 3.0.1.

Release notes

Sourced from doctrine/lexer's releases.

3.0.1

Release Notes for 3.0.1

3.0.x bugfix release (patch)

3.0.1

  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1

Test Suite

Other changes

  • This release contains all changes that shipped with 2.1.1.

3.0.0

Release Notes for 3.0.0

Backwards incompatible release (major)

3.0.0

Upgrade guide

Sourced from doctrine/lexer's upgrade guide.

Note about upgrading: Doctrine uses static and runtime mechanisms to raise awareness about deprecated code.

  • Use of @deprecated docblock that is detected by IDEs (like PHPStorm) or Static Analysis tools (like Psalm, phpstan)
  • Use of our low-overhead runtime deprecation API, details: https://github.com/doctrine/deprecations/

Upgrade to 3.0.0

Doctrine\Common\Lexer\Token no longer implements ArrayAccess. Parameter type declarations have been added to Doctrine\Common\Lexer\AbstractLexer and Doctrine\Common\Lexer\Token. You should add both parameter type declarations and return type declarations to your lexers, based on the @return phpdoc.

Upgrade to 2.0.0

AbstractLexer::glimpse() and AbstractLexer::peek() now return instances of Doctrine\Common\Lexer\Token, which is an array-like class Using it as an array is deprecated in favor of using properties of that class. Using count() on it is deprecated with no replacement.

Commits
  • 31ad66a PHPUnit 10 (#117)
  • 9a3516d Merge branch '2.1.x' into 3.0.x
  • 84a527d Merge pull request #80 from greg0ire/php8-syntax
  • c4f371c Drop support for php < 8.1
  • c391831 Merge pull request #104 from doctrine/2.1.x-merge-up-into-3.0.x_GyzLhYcQ
  • b3bd837 Merge remote-tracking branch 'origin/2.1.x' into 2.1.x-merge-up-into-3.0.x_Gy...
  • c00280c Merge pull request #97 from greg0ire/cleanup-psalm-rules
  • 6f9d67d Trigger static analysis workflow on psalm* change
  • cb7b93e Remove rules related to BC layer
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [doctrine/lexer](https://github.com/doctrine/lexer) from 2.1.1 to 3.0.1.
- [Release notes](https://github.com/doctrine/lexer/releases)
- [Upgrade guide](https://github.com/doctrine/lexer/blob/3.0.x/UPGRADE.md)
- [Commits](doctrine/lexer@2.1.1...3.0.1)

---
updated-dependencies:
- dependency-name: doctrine/lexer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (85d0c5b) to head (f3c55c7).

Additional details and impacted files
@@            Coverage Diff             @@
##              4.3    #6271      +/-   ##
==========================================
- Coverage   82.83%   82.72%   -0.11%     
==========================================
  Files         480      480              
  Lines       27093    27093              
==========================================
- Hits        22442    22413      -29     
- Misses       4651     4680      +29     
Flag Coverage Δ
E2E 82.72% <ø> (-0.11%) ⬇️
Unit 82.72% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dotani1111 dotani1111 added this to the 4.3.x milestone Aug 26, 2024
@dotani1111
Copy link
Contributor

テストが落ちています。

  1. Eccube\Tests\Repository\CustomerRepositoryGetQueryBuilderBySearchDataTest::testBirthMonth
    Error: Cannot use object of type Doctrine\Common\Lexer\Token as array

Upgrade to 3.0.0に以下の記載があり、修正が必要です。

Doctrine\Common\Lexer\AbstractLexer and Doctrine\Common\Lexer\Token. You should add both parameter type declarations and return type declarations to your lexers, based on the @return phpdoc.

@ji-eunsoo
Copy link
Contributor

下位互換性のチェックが必要です

@dotani1111
Copy link
Contributor

最新取り込んでテストの再実行してみる。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants