Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

300-Allow-the-MDLTableWidget-to-be-paginated #304

Open
wants to merge 15 commits into
base: development
Choose a base branch
from
Open

300-Allow-the-MDLTableWidget-to-be-paginated #304

wants to merge 15 commits into from

Conversation

juliendelplanque
Copy link
Contributor

Implemented pagination for MDLTableWidget.
Used a strategy design pattern to achieve that, the strategy is used to generate html for the content of the table.
Implemented tests.

Fix #300

@juliendelplanque
Copy link
Contributor Author

Not entirely finished, there is still a bug with the pagination size selection..

@coveralls
Copy link

coveralls commented Apr 1, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 613

  • 113 of 204 (55.39%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 65.511%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Material-Design-Lite-Widgets/MDLTableWidget.class.st 26 38 68.42%
src/Material-Design-Lite-Widgets/MDLDisplayPaginatedTableContent.class.st 69 148 46.62%
Totals Coverage Status
Change from base Build 602: -0.4%
Covered Lines: 3400
Relevant Lines: 5190
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc jecisc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the MDLTableWidget to be paginated
3 participants
@juliendelplanque @coveralls @jecisc