MD5.xs - remove meaningless type qualifier on cast type #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the HPUX Itanium compiler (which is very picky), we get warnings
about the second "const" in these casts. Removing them makes the
compiler happy doesn't seem to do any harm.
"MD5.xs", line 470: warning #2191-D: type qualifier is meaningless on cast type
&& mg->mg_virtual == (const MGVTBL * const)&vtbl_md5) {
^
"MD5.xs", line 492: warning #2191-D: type qualifier is meaningless on cast type
sv_magicext(sv, NULL, PERL_MAGIC_ext, (const MGVTBL * const)&vtbl_md5, (const char *)context, 0);
Includes a version bump to 2.59, Changes update and test updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the HPUX Itanium compiler (which is very picky), we get warnings about the second "const" in these casts. Removing them makes the compiler happy doesn't seem to do any harm.
"MD5.xs", line 470: warning #2191-D: type qualifier is meaningless on cast type
&& mg->mg_virtual == (const MGVTBL * const)&vtbl_md5) {
^
"MD5.xs", line 492: warning #2191-D: type qualifier is meaningless on cast type
sv_magicext(sv, NULL, PERL_MAGIC_ext, (const MGVTBL * const)&vtbl_md5, (const char *)context, 0);
Includes a version bump to 2.59, Changes update and test updates.