Don't try to utime an open file on VMS #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigberry
added a commit
to Perl/perl5
that referenced
this pull request
Aug 17, 2024
Also sent upstream: Dual-Life/autodie#121
toddr
reviewed
Aug 19, 2024
t/utime.t
Outdated
| @@ -8,6 +8,7 @@ use autodie; | |||
| use File::Temp qw(tempfile); | |||
|
|
|||
| my ($fh, $filename) = tempfile; | |||
| close $fh if $^O eq 'VMS'; # can't utime an open file | |||
There was a problem hiding this comment.
Thanks @craigberry, wouldn't we be better to ALWAYS do this, not just for VMS? Then if it is needed, at least we'll notice the bug before VMS has to suffer with it?
There was a problem hiding this comment.
I'm ok with always doing it -- I was just trying to limit the scope to where I knew it was needed.
There was a problem hiding this comment.
I've revised the commit to close the filehandle without checking platform. I couldn't build and test it locally since there's no Makefile.PL.
6407f65 changed to using File::Temp to create the temp file for this test, which implicitly opens it for exclusive access on VMS and prevents the ability to call utime on it. The filehandle is not used so just close it.
|
We'll need to sort the CI issues before I'll ship a new version could be a week or so because I'm waiting on upstream changes. |
rawleyfowler
pushed a commit
to rawleyfowler/perl5
that referenced
this pull request
Sep 2, 2024
Also sent upstream: Dual-Life/autodie#121
|
You can see what I did in my basic GitHub workflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6407f65 changed to using File::Temp to create the temp file for this test, which implicitly opens it for exclusive access and prevents the ability to call utime on it.