Fixes for Makefile #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, those libs are not in "thirdparty" dir anyway. Second, I see no static libs in Archlinux "bullet" package, only dynamic. And third, I just see no reason to link them statically instead of being shared with other apps of the system.
Removing the lib causes no problems to compilation, so the library is not even used in the code. Besides, such a library not even shipped in packages — checked at least on Archlinux and Ubuntu.
|
Though wait, don't merge it, I noticed that I have to build with |
|
As I mentioned in the comment to question, Reopening PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.