Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed line 2108 in cvui.h #77

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Removed line 2108 in cvui.h #77

merged 2 commits into from
Apr 8, 2020

Conversation

Andyalevy
Copy link

Hi. This PR solves the bug stated in #71.

Dovyski and others added 2 commits November 11, 2018 14:33
This line called the function cv::rectangle from opencv with an empty
Mat, which throws an exception
@Dovyski
Copy link
Owner

Dovyski commented Apr 10, 2019

Hi and thank you for your contributions! Pull requests should be made against the dev branch of cvui instead of master. Do you mind changing your pull request to target the dev branch, please?

@Andyalevy Andyalevy changed the base branch from master to dev April 10, 2019 11:31
@Andyalevy
Copy link
Author

I changed the base to dev. Sorry for the misunderstanding.

@Dovyski
Copy link
Owner

Dovyski commented Apr 10, 2019

Thank you! No need to be sorry, it's my own fault not to document those things ;)

@Dovyski
Copy link
Owner

Dovyski commented Apr 11, 2019

Thank you! 🎉 I'll merge your PR along with the other PRs as soon as I have some free time to work on cvui.

@Andyalevy
Copy link
Author

Thanks! And thank you for the work you've done, cvui is extremely useful :)

@Dovyski
Copy link
Owner

Dovyski commented Apr 12, 2019

The pleasure is all mine to see cvui being used. And to receive time and energy from other developers to help improve it. Thank you! :)

@bonukai bonukai mentioned this pull request Aug 27, 2019
@freetomik
Copy link

Hello, remainder, that this should be merged. Almost year after this report, I hit the assertion error of #81 in debug mode. So I fixed it locally, and then found this old report. Please merge...

@Dovyski Dovyski merged commit a69bb38 into Dovyski:dev Apr 8, 2020
@Dovyski
Copy link
Owner

Dovyski commented Apr 8, 2020

Ok, merged. I am truly sorry for the absence regarding the maintenance of this project in the last year. I am doing my best to allocate time for it.

@freetomik
Copy link

Thank you for the merge. I can understand the lack of time. Thanks for this useful tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants