Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port : Exclude pre-releases from NuGet latest version check #1595

Merged

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Nov 22, 2024

Description

This PR addressed the issue of pre-release nuget packages being returned as the latest version.

The Nuget Documentation identifies packages with a "-" in their version string as a pre-release package.

The change is to filter the list of Nuget Packages that contain an "-" when determining the latestVersion. If the component being inspected is a pre-release itself, then pre-release versions are not filtered.

Addressed Issue

Port change : #1358

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Co-Authored-By: Brent England <[email protected]>
Co-Authored-By: brentengland-scc <[email protected]>
@sahibamittal sahibamittal added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels Nov 22, 2024
@sahibamittal sahibamittal added this to the 0.6.0 milestone Nov 22, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+18.35% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (dba56d9) 201 132 65.67%
Head commit (c98a490) 6898 (+6697) 5796 (+5664) 84.02% (+18.35%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1595) 10 10 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit a4af29c into main Nov 22, 2024
13 checks passed
@nscuro nscuro deleted the port-exclude-pre-releases-from-NuGet-latest-version-check branch November 22, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants