Do not use ingress.hostname for frontend.apiBaseUrl
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt use ingress hostname here Signed-off-by: Pawel Mrowka <[email protected]>
🐛 apiBaseUrl without protocol (http/s) is added after domain, - w…
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Update helm docs
|
this tiny problem is very annoying. because of this issue, I had to do it locally :( fix it, please! |
nscuro
changed the title
ingress.hostname for frontend.apiBaseUrl
nscuro
added a commit
that referenced
this pull request
Jun 12, 2024
Includes changes from: * #13 * #22 * #23 * #33 * #34 * #42 * #52 * #55 * #57 * #83 * #87 Co-authored-by: Pawel Mrowka <[email protected]> Co-authored-by: Edvin Norling <[email protected]> Co-authored-by: Jaz Ark <[email protected]> Co-authored-by: Arnaud Hatzenbuhler <[email protected]> Co-authored-by: Stefan Hynek <[email protected]> Co-authored-by: Theodor van Nahl <[email protected]> Co-authored-by: Sergiy Kulanov <[email protected]> Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Jun 12, 2024
Includes changes from: * #13 * #22 * #23 * #33 * #34 * #42 * #52 * #55 * #57 * #83 * #87 Co-authored-by: Pawel Mrowka <[email protected]> Co-authored-by: Edvin Norling <[email protected]> Co-authored-by: Jaz Ark <[email protected]> Co-authored-by: Arnaud Hatzenbuhler <[email protected]> Co-authored-by: Stefan Hynek <[email protected]> Co-authored-by: Theodor van Nahl <[email protected]> Co-authored-by: Sergiy Kulanov <[email protected]> Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Jun 12, 2024
Includes changes from: * #13 * #22 * #23 * #33 * #34 * #42 * #52 * #55 * #57 * #83 * #87 Co-authored-by: Pawel Mrowka <[email protected]> Co-authored-by: Edvin Norling <[email protected]> Co-authored-by: Jaz Ark <[email protected]> Co-authored-by: Arnaud Hatzenbuhler <[email protected]> Co-authored-by: Stefan Hynek <[email protected]> Co-authored-by: Theodor van Nahl <[email protected]> Co-authored-by: Sergiy Kulanov <[email protected]> Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Jun 12, 2024
Includes changes from: * #13 * #22 * #23 * #33 * #34 * #42 * #52 * #55 * #57 * #83 * #87 Signed-off-by: nscuro <[email protected]> Co-authored-by: Pawel Mrowka <[email protected]> Co-authored-by: Edvin Norling <[email protected]> Co-authored-by: Jaz Ark <[email protected]> Co-authored-by: Arnaud Hatzenbuhler <[email protected]> Co-authored-by: Stefan Hynek <[email protected]> Co-authored-by: Theodor van Nahl <[email protected]> Co-authored-by: Sergiy Kulanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the value from Values.ingress.hostname, such as 'example.com', is used, the frontend attempts to send requests to 'example.com/example.com/api/...'.