-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make service ports configurable #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some comments to explain some points.
…changing the ports Signed-off-by: Felipe Rios <[email protected]>
97a44fc
to
06ed560
Compare
Can you elaborate on your problem? How are you configuring the load balancing and why do the hardcoded service ports prevent your setup from working? |
Well, when you try to create 2 load balancers, they will be pointing to an external IP in port 8080. I'm required to type the port. And if I create a DNS like CloudFlare for those external IPs, it won't work in port 80. I'll have to make extra effort to have it working in port 80. Like patching the services, or creating my own services (which is the approach I'm doing). Look at the SonarQube Helm Chart for example: https://github.com/SonarSource/helm-chart-sonarqube/blob/master/charts/sonarqube/values.yaml#L68. If they don't do that, I'll be obligated to type: |
Ah I see, so you're using |
Yes! I'm exposing both directly, and I have DNS for both. Yes! I'm using |
It allows the practitioner to change the ports of each service. Now, I'm using the chart and I'm not able to expose the load balancers with the port 80 because of that. With this code, I'm solving this issue.