Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make service ports configurable #158

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

rios0rios0
Copy link
Contributor

It allows the practitioner to change the ports of each service. Now, I'm using the chart and I'm not able to expose the load balancers with the port 80 because of that. With this code, I'm solving this issue.

@rios0rios0 rios0rios0 requested a review from a team as a code owner September 19, 2024 00:44
charts/hyades/README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rios0rios0 rios0rios0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments to explain some points.

@nscuro
Copy link
Member

nscuro commented Sep 19, 2024

Now, I'm using the chart and I'm not able to expose the load balancers with the port 80 because of that.

Can you elaborate on your problem? How are you configuring the load balancing and why do the hardcoded service ports prevent your setup from working?

@rios0rios0
Copy link
Contributor Author

Now, I'm using the chart and I'm not able to expose the load balancers with the port 80 because of that.

Can you elaborate on your problem? How are you configuring the load balancing and why do the hardcoded service ports prevent your setup from working?

Well, when you try to create 2 load balancers, they will be pointing to an external IP in port 8080. I'm required to type the port. And if I create a DNS like CloudFlare for those external IPs, it won't work in port 80. I'll have to make extra effort to have it working in port 80. Like patching the services, or creating my own services (which is the approach I'm doing). Look at the SonarQube Helm Chart for example: https://github.com/SonarSource/helm-chart-sonarqube/blob/master/charts/sonarqube/values.yaml#L68. If they don't do that, I'll be obligated to type: sonar.mycompany.com:9000. Which actually is not so helpful, or seamless.

@nscuro
Copy link
Member

nscuro commented Sep 19, 2024

Ah I see, so you're using service.type: LoadBalancer then? I think I got a bit confused as to what load balancer you meant. So far most people just use an ingress instead of exposing the services directly.

@nscuro nscuro added the enhancement New feature or request label Sep 19, 2024
@rios0rios0
Copy link
Contributor Author

Ah I see, so you're using service.type: LoadBalancer then? I think I got a bit confused as to what load balancer you meant. So far most people just use an ingress instead of exposing the services directly.

Yes! I'm exposing both directly, and I have DNS for both. Yes! I'm using LoadBalancer.

@nscuro nscuro changed the title feat(flexible-port): added a new parameter in both services to allow changing the ports Make service ports configurable Sep 19, 2024
@nscuro nscuro merged commit 8bedcc8 into DependencyTrack:main Sep 19, 2024
4 checks passed
@rios0rios0 rios0rios0 deleted the feat/flexible-port branch September 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants