Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /health endpoint support when using ingress #154

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

RankXen
Copy link
Contributor

@RankXen RankXen commented Sep 11, 2024

Description / issue

  • Add support for the /health endpoint introduced in version 4.8.0+ (https://docs.dependencytrack.org/getting-started/monitoring/)
  • Because of the current ingress configuration the /health endpoint will direct traffic to the frontend which will return a 404 Not found whereas the api-server should handle the route

How to test

  • Apply helm chart with ingress enabled

Note: I already tested on an dependency track deployment running on openshift (chart version 0.15.0) by simply adding:

(note that dtrack-dev is the deployment name I used)

- path: /health
  pathType: Prefix
  backend:
    service:
      name: dtrack-dev-dependency-track-api-server
      port:
        name: web

On GET \health I know properly get:
{"status":"UP","checks":[{"name":"database","status":"UP","data":{"nontx_connection_pool":"UP","tx_connection_pool":"UP"}}]}

Signed-off-by: RankXen <[email protected]>
@RankXen RankXen requested a review from a team as a code owner September 11, 2024 12:29
@nscuro nscuro added the enhancement New feature or request label Sep 11, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nscuro nscuro merged commit 753d89e into DependencyTrack:main Sep 11, 2024
4 checks passed
@RankXen
Copy link
Contributor Author

RankXen commented Sep 11, 2024

Thank you for approval & merge.
Upgraded to v0.19.0, works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants