Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Add Version" Create Button Should Be Inactive Until Version Provided #1039

Conversation

IdrisGit
Copy link
Contributor

@IdrisGit IdrisGit commented Oct 8, 2024

Description

I have added a fix to keep the create button inactive until a value is provided in the version input field. This is to improve the form's UX and prevent invalid submissions.

Addressed Issue

Fixes #995

Additional Details

Create button disabled when version field is empty

add-version-disable

Create button enabled when version field is empty

add-version-enable

Checklist

added a fix to keep the create button inactive until any value is provided in the version input
this is to improve the UX of the form and prevent invalid submission

Signed-off-by: idrisGit <[email protected]>
@nscuro nscuro added this to the 4.13 milestone Oct 9, 2024
@nscuro nscuro added defect Something isn't working hacktoberfest Issues eligible for Hacktoberfest contributions hacktoberfest-accepted Accepted Hacktoberfest contributions labels Oct 9, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great work!

@nscuro nscuro merged commit 58f5231 into DependencyTrack:master Oct 9, 2024
10 checks passed
@nscuro nscuro added the backport/4.12.1 PRs to be backported to version 4.12.1 label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/4.12.1 PRs to be backported to version 4.12.1 defect Something isn't working hacktoberfest Issues eligible for Hacktoberfest contributions hacktoberfest-accepted Accepted Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add Version" Create Button Should Be Inactive Until Version Provided
2 participants