Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1244 reading dependent variable output #1245

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Issue #1244 reading dependent variable output #1245

merged 14 commits into from
Oct 22, 2024

Conversation

HendrikKok
Copy link
Contributor

@HendrikKok HendrikKok commented Oct 17, 2024 •
edited
Loading

Fixes #1244

Description

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

Huite
Huite requested changes Oct 17, 2024
View reviewed changes
docs/api/changelog.rst Outdated Show resolved Hide resolved
docs/api/changelog.rst Outdated Show resolved Hide resolved
imod/mf6/out/__init__.py Show resolved Hide resolved
imod/mf6/out/__init__.py Show resolved Hide resolved
@Huite Huite mentioned this pull request Oct 18, 2024
Open
@HendrikKok HendrikKok requested a review from Huite October 21, 2024 10:48
@JoerivanEngelen JoerivanEngelen marked this pull request as ready for review October 21, 2024 13:07
JoerivanEngelen
JoerivanEngelen approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick, but looks good!

Could you remove that one line? Approving in advance!

imod/tests/test_mf6/test_mf6_uzf_model.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@HendrikKok HendrikKok added this pull request to the merge queue Oct 22, 2024
Merged via the queue into master with commit cf51d1e Oct 22, 2024
6 checks passed
@HendrikKok HendrikKok deleted the issue_#1244_reading-dependent-variable-output branch October 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huite Huite Huite approved these changes

@JoerivanEngelen JoerivanEngelen JoerivanEngelen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for reading watercontent-file of UZF-package
3 participants
@HendrikKok @JoerivanEngelen @Huite