GRIDEDIT-1522: Bug Fix, missing circumcenters calculations #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacarniato
changed the title
lucacarniato
changed the title
BillSenior
reviewed
Nov 11, 2024
libs/MeshKernel/src/Operations.cpp
Outdated
Comment on lines
1155
to
1156
|
|
||
| double maxValue = std::max(std::max(std::abs(x21), std::abs(y21)), | ||
| std::max(std::abs(x43), std::abs(y43))); | ||
| const double eps = std::max(0.00001 * maxValue, std::numeric_limits<double>::denorm_min()); | ||
|
|
||
| if (std::abs(det) < eps) | ||
| if (IsEqual(det, 0.0)) |
There was a problem hiding this comment.
The way that IsEqual is implemented in the master, this will (IsEqual(det, 0.0)) always return false (unless det == 0.0) So I think the previous version was the better check in this case
BillSenior
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.