Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spark totalVolume onboarding #2108

Merged
merged 6 commits into from
Nov 21, 2024
Merged

spark totalVolume onboarding #2108

merged 6 commits into from
Nov 21, 2024

Conversation

PaulZhemanov
Copy link
Contributor

No description provided.

@llamatester
Copy link

The spark adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs spark

🦙 Running SPARK adapter 🦙
---------------------------------------------------
Start Date:	Tue, 19 Nov 2024 00:00:00 GMT
End Date:	Wed, 20 Nov 2024 00:00:00 GMT
---------------------------------------------------

Trade Volume: 4794.2208423282755
Timestamp: 1732093200
FUEL 👇
Backfill start time: 30/9/2020
NO METHODOLOGY SPECIFIED
Total volume: 4.79 k
End timestamp: 1732093200 (2024-11-20T09:00:00.000Z)

@llamatester
Copy link

The spark adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs spark

🦙 Running SPARK adapter 🦙
---------------------------------------------------
Start Date:	Tue, 19 Nov 2024 00:00:00 GMT
End Date:	Wed, 20 Nov 2024 00:00:00 GMT
---------------------------------------------------

Trade Volume: 4813.46517827553
Timestamp: 1732111200
FUEL 👇
Backfill start time: 30/9/2020
NO METHODOLOGY SPECIFIED
Total volume: 4.81 k
End timestamp: 1732111200 (2024-11-20T14:00:00.000Z)

@dtmkeng
Copy link
Contributor

dtmkeng commented Nov 20, 2024

could you return dailyVolume ?

dtmkeng
dtmkeng requested changes Nov 20, 2024
View reviewed changes
dexs/spark/index.ts Outdated
console.log('Timestamp:', timestamp);

return {
totalVolume: totalVolume,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add dailyVolume ?

@llamatester
Copy link

The spark adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs spark

🦙 Running SPARK adapter 🦙
---------------------------------------------------
Start Date:	Wed, 20 Nov 2024 00:00:00 GMT
End Date:	Thu, 21 Nov 2024 00:00:00 GMT
---------------------------------------------------

FUEL 👇
Backfill start time: 30/9/2020
NO METHODOLOGY SPECIFIED
Daily volume: 55
End timestamp: 1732182780 (2024-11-21T09:53:00.000Z)

@PaulZhemanov
Copy link
Contributor Author

@llamatester Hi! could you check updates please?

@llamatester
Copy link

The spark adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs spark

🦙 Running SPARK adapter 🦙
---------------------------------------------------
Start Date:	Wed, 20 Nov 2024 08:20:55 GMT
End Date:	Thu, 21 Nov 2024 08:20:55 GMT
---------------------------------------------------

FUEL 👇
Backfill start time: 6/11/2024
NO METHODOLOGY SPECIFIED
Daily volume: 54
End timestamp: 1732177254 (2024-11-21T08:20:54.000Z)

@g1nt0ki g1nt0ki merged commit 9580a5d into DefiLlama:master Nov 21, 2024
2 checks passed
@g1nt0ki
Copy link
Member

g1nt0ki commented Nov 21, 2024

@PaulZhemanov thanks for the PR

buchaoqun added a commit to solv-finance-dev/dimension-adapters that referenced this pull request Nov 22, 2024
@buchaoqun
Merge branch 'master' of github.com:solv-finance-dev/dimension-adapters
1ffc972 
* 'master' of github.com:solv-finance-dev/dimension-adapters: (146 commits)
  Add ninja blaze adapter (DefiLlama#2111)
  feat: integrate mach exchange (DefiLlama#2112)
  add phantom
  fix pf
  fix xdai
  spark totalVolume onboarding (DefiLlama#2108)
  add bitget wallet volume (DefiLlama#2059)
  track adrena DefiLlama#2109
  use string timestamp
  track titan DefiLlama#2113
  pool update
  update sdk version
  disable xdai
  fix: volume for Bountive V2
  feat: update meme cooking for new api
  Goat Protocol Fees & Revenue
  delete
  prevent spike;
  track blazingbot DefiLlama#2104
  fix version and get daily value
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtmkeng dtmkeng dtmkeng requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PaulZhemanov @llamatester @dtmkeng @g1nt0ki