feat(trace-agent): Add readiness probe to datadog-agent trace-agent container #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using the Datadog service (e.g.,
http://datadog-agent:8126/v0.5/traces), the endpoint for a newly created pod becomes available as soon as the pod become ready and the readinessProbe succeeds.Currently, the
datadog-agenthas areadinessProbeconfigured for the agent, but not for thetrace-agent. As a result, thetrace-agentmay start receiving traffic before it is fully ready.This PR adds a
readinessProbefor the trace-agent to ensure it only begins receiving traffic once it is ready to accept traffic, preventing potential issues with premature traffic handling.Which issue this PR fixes
While this is not a complete fix for issue #17310, it will help lower the number of failed messages.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdFor Datadog Operator chart or value changes update the test baselines (run:make update-test-baselines)