Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-9550 - Evaluations with BYOK #26416

Merged
merged 7 commits into from
Nov 27, 2024
Merged

DOCS-9550 - Evaluations with BYOK #26416

merged 7 commits into from
Nov 27, 2024

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Nov 21, 2024

What does this PR do? What is the motivation?

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Can someone confirm where in the app you enter topics? From the figma it looks like it'll be https://app.datadoghq.com/llm/settings/applications

@cswatt cswatt requested a review from a team as a code owner November 21, 2024 16:49
@cswatt cswatt added the WORK IN PROGRESS No review needed, it's a wip ;) label Nov 21, 2024
@github-actions github-actions bot added the Images Images are added/removed with this PR label Nov 21, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@cswatt cswatt removed the WORK IN PROGRESS No review needed, it's a wip ;) label Nov 21, 2024
1. Go to [**LLM Observability > Applications**][5].
1. Select the application you want to add topics for.
1. At the bottom of the left sidebar, select **Configuration**.
1. Add topics in the pop-up modal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @barieom, can you confirm that this is the correct location to enter topics?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be correct in app.datadoghq!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's correct!

Copy link
Contributor

@barieom barieom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple comments, thanks for getting this out cecilia!

@@ -21,28 +21,55 @@ Topics
: Helps identify irrelevant input for the `topic relevancy` out-of-the-box evaluation, ensuring your LLM application stays focused on its intended purpose.

Evaluations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we swap the order of topic relevancy and evaluations here?


After you click **Save**, LLM Observability invokes a `GPT-4o mini` model using the OpenAI API key you provided.

You can monitor the usage of this API key by querying for the metrics `ml_obs.span.llm.input.tokens`, `ml_obs.span.llm.output.tokens`, and `ml_obs.span.llm.total.tokens`. Filter by the `evaluation:default` tag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cswatt - could we hold off on this sentence for this release? we'll release this metric after reinvent, as there are some cross product impact of releasing this metric that we want to address

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the line!

content/en/llm_observability/configuration/_index.md Outdated Show resolved Hide resolved

## Select and enable evaluations

Navigate to [**LLM Observability > Settings > Evaluations**][3].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a step in the list


Select an LLM application set up with LLM Observability to start customizing its topics and evaluations.
{{< img src="llm_observability/configuration/settings.png" alt="The Evaluations tab, featuring a list of existing evaluations." style="width:100%;" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This screenshot feels unnecessary to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@cswatt
Copy link
Contributor Author

cswatt commented Nov 27, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 27, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-27 19:24:28 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-27 19:35:42 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 8m.

@dd-mergequeue dd-mergequeue bot deleted the cswatt/byok branch November 27, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants