fix: telemetry refactoring part 1 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
force-pushed
the
dmehala/fix/part-1-keep-reference-on-user-metrics
branch
from
cb02a99
to
b188655
Compare
dmehala
requested review from
dubloom and
pablomartinezbernardo
and removed request for
a team and
dubloom
Keep a reference to user metrics to avoid dereferencing them when they are not alive anymore.
dmehala
force-pushed
the
dmehala/fix/part-1-keep-reference-on-user-metrics
branch
from
b188655
to
516e3a4
Compare
BenchmarksBenchmark execution time: 2024-10-30 17:12:18 Comparing candidate commit 516e3a4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 93.95% 93.95%
=======================================
Files 73 73
Lines 4170 4171 +1
=======================================
+ Hits 3918 3919 +1
Misses 252 252 ☔ View full report in Codecov by Sentry. |
zacharycmontoya
approved these changes
Nov 4, 2024
dmehala
restored the
dmehala/fix/part-1-keep-reference-on-user-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keep a reference to user metrics to avoid dereferencing them when they are not alive anymore.