[part 1] refactor!: expose telemetry module #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is the first part of the telemetry module refactoring. Part of the refactoring is to make the telemetry module publicly usable by other Datadog products without any dependencies on the tracer. - Replace report_telemetry with telemetry configuration struct
dmehala
requested review from
pablomartinezbernardo
and removed request for
a team
pablomartinezbernardo
approved these changes
Oct 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 94.67% 93.95% -0.72%
==========================================
Files 72 73 +1
Lines 3810 4170 +360
==========================================
+ Hits 3607 3918 +311
- Misses 203 252 +49 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This the first PR in a series of PR aiming at refactoring the telemetry module. The purpose of this refactoring
is to support external usage of the library without the tracer, serializing payloads in MessagePack, supporting the few gaps in the current implementation (unsupported env var, logs, histogram, etc.)
Part 1 of the refactoring is to make the telemetry module publicly usable by other Datadog products without any dependencies on the tracer.
NOTE TO REVIEWER: This is not the sexiest PR but is the foundation of the following one.
Changes
report_telemetryconfiguration with telemetry configuration struct.