-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Set a default service name (DD_SERVICE) when no service is configured #158
feat!: Set a default service name (DD_SERVICE) when no service is configured #158
Conversation
BenchmarksBenchmark execution time: 2024-10-07 14:09:05 Comparing candidate commit bb5065c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
4bd244f
to
51d33e8
Compare
…ame value when none is provided by DD_SERVICE or configuration Issues: APMAPI-709
…figuration so we can test default behaviors Issues: APMAPI-708 , APMAPI-709
51d33e8
to
c312c99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 72 72
Lines 3804 3806 +2
=======================================
+ Hits 3601 3603 +2
Misses 203 203 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Propose changes to consider cases where the underlying function can fail for Darwin and Windows NT.
Co-authored-by: Damien Mehala <[email protected]>
Description
Adds a default service for the configuration if none was set in the
DD_SERVICE
environment variable or user configuration. This is a breaking change as previously a missing service would throw a configuration initialization error.The default value will be set to the name of the executable.
Motivation
This aligns the cpp tracer behavior for an unconfigured
DD_SERVICE
with the expected behavior of all the tracers in our Config Consistency initiative.Additional Notes
Also updates the parametric test so that the DD_ENV behavior works as expected.
This has been tested on Ubuntu 24.04 (run on a Windows machine in WSL), Windows 11, and macOS Monterey
Jira ticket: APMAPI-709 APMAPI-708