-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introduce public/private headers #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
commented
Aug 14, 2024
], | ||
strip_include_prefix = "src/", | ||
strip_include_prefix = "include/", | ||
copts = ["-Isrc/datadog"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still needed?
dmehala
changed the title
refactor: public/private headers
refactor: introduce public/private headers
Aug 14, 2024
dmehala
force-pushed
the
dmehala/api/public-private-headers
branch
from
August 14, 2024 15:46
7163456
to
9b24099
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 73 72 -1
Lines 3811 3797 -14
=======================================
- Hits 3600 3587 -13
+ Misses 211 210 -1 ☔ View full report in Codecov by Sentry. |
dmehala
force-pushed
the
dmehala/api/public-private-headers
branch
2 times, most recently
from
August 14, 2024 17:04
6854d22
to
f908a27
Compare
dmehala
force-pushed
the
dmehala/api/public-private-headers
branch
from
August 14, 2024 17:08
f908a27
to
cf58690
Compare
pablomartinezbernardo
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactor organizes the library headers into public and private categories. Public headers are now exposed in the
include
directory for external use, while private headers are kept withinsrc
directory.Motivation
To establish a clear separation between the public API and internal code, enhancing maintainability and simplifying the usage of the library.
Additional Notes
The current refactor is still a work in progress. As you can see there's already a lot of changes and I did not want to push a huge PR too difficult to review. I will gradually improve that separation with subsequent PR.
Here's an exhaustive list of remaining work:
rate.h
from the public API.json_fwd.h
from the public API.sampling_decision.h
from the public API.sampling_mechanism.h
from the public API.span_defaults.h
from the public API.span_matcher.h
from the public API.Remove(trace_segment.h
from the public API.trace_segment
is the trace context. Probably worth a renaming).include-what-you-use
.