Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-6563] Attribute ressource URL to LCP #3154

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Nov 21, 2024

Motivation

LCP is often caused by a big image being rendered. If we can find which image was loaded at that time, we could have a field like: @view.largest_contentful_paint_resource_url:https://...

Changes

Adding new field to indicate the ressource url of the largest contentful paint

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@RomanGaignault RomanGaignault requested a review from a team as a code owner November 21, 2024 08:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (7ea12b0) to head (d314d33).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
+ Coverage   93.43%   93.45%   +0.01%     
==========================================
  Files         280      280              
  Lines        7679     7680       +1     
  Branches     1719     1720       +1     
==========================================
+ Hits         7175     7177       +2     
+ Misses        504      503       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@RomanGaignault RomanGaignault changed the title [RUM-6563] Attribute ressource URL to LCP ✨ [RUM-6563] Attribute ressource URL to LCP Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants