improve uncertainty numbers for annual and multi-year estimates #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes relevant to DOI-USGS/loadflex#174 and concurrent with DOI-USGS/loadflex#197
As noted in DOI-USGS/loadflex#174, this is a thornier issue than I can solve completely this month. aggregateSolute has no mechanism to account for correlation in estimation error due to parameter uncertainty, an oversight that I can bypass for loadReg models by using period-specific uncertainty straight from rloadest, but that will require a more extensive (bootstrap?) solution for composite and interpolation models. So the batch script now reports the uncertainty for these non-regression models as NA. It's probably fair to assume that when the use of the composite method is justified, its uncertainty is smaller than the upper bound set by the regression model. Interpolation models could be more or less uncertain.