flesh out summarizeModel framework and loadReg2 method #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of usgs_github:USGS-R/loadflex into issue152 # Conflicts: # man/getPVal.Rd
|
@wdwatkins - i think this PR is ready to go. could you review and merge? |
wdwatkins
approved these changes
Jan 26, 2017
|
|
||
| # summarize the coefficient estimates, standard errors, and p-values | ||
| coefs <- coef(load.model, summary=TRUE, which=loadReg.model) |
| #' @export | ||
| #' @family summarizeModel | ||
| summarizeModel.loadReg2 <- function(load.model, ...) { | ||
| out <- summarizeModel(getFittedModel(load.model), ...) |
| retDF <- data.frame( | ||
| RMSE = rmse(load.model, model=loadReg.model), | ||
| r.squared = loadReg.fit$RSQ, # R-square needs to change when censored values are present!! see print.loadReg.R line 131 in rloadest. is this adjusted? |
There was a problem hiding this comment.
We'll need to remember to update this when we deal with #144
|
Good thoughts, thanks. I renamed to summarize.R to summarizeData.R - not perfect, because it's iffy whether predictions==data, but an improvement over the way-too-generic summarize, as you pointed out. |
|
I guess travis and appveyor were just on break or something 🤷♂️ merging |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #152