-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3218 editorial todo editor #2123
Conversation
…ditorial_todo--editor
… some changes to the associate view calculations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richard-jones & @dommitchell Just a quick comment: once a priority item gets escalated from an associate editor up to their managing editor, does it get removed from their own priority item list? This is what I am seeing but I’m not sure if it’s the intended behaviour. I think it might be counterintuitive since they would no longer be aware that their applications need urgent attention.
For example, in my dataset, I am ManEd of Turkish 1. The user Ramazan
has 9 ongoing applications, as shown in my editorial activity chart, and all of them are in my priority queue as ManEd. However, when I log into Ramazan
’s account, I get the message:
...which isn’t true at all, since they do have plenty of urgent items, we’re just not showing them anymore.
…r--UI_bits Feature/3218 editorial todo editor UI bits
…r--spellout spell out the roles
…r--card-actions change the cards' text action
Ported a couple of if-else in the dashboard nav, todo is merged in to workflow branch
… merged up to the editorial dashboard branch for finishing
Editor and Associate Editor Dashboard pages
Please don't delete any sections when completing this PR template; instead enter N/A for checkboxes or sections which are not applicable, unless otherwise stated below
See https://github.com/DOAJ/doajPM/issues/3218
This PR introduces several new features:
The associate editor and editor criteria for the dashboard are implemented as specified here https://docs.google.com/spreadsheets/d/1WJLsbtx3wkdNeakrnP3QkvSYls4uFw0lPPzychq7Mo4/edit#gid=0
Categorisation
This PR...
Basic PR Checklist
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
(or other base branch)Testing
The functional tests are here
https://docs.google.com/spreadsheets/d/1fT9TD4dzxNclhAB0Ax_yuoQGHBY2m2i8Cefs_8kD5Nc/edit#gid=0
To run these tests you need to use the new "testdrive" endpoint, which will set the application up for testing. Each functional test tells you which endpoint to use, and they can be accessed by putting the url into your browser (you must be logged into DOAJ on the test machine for this to work):
https://testdoaj.cottagelabs.com/testdrive/[name of testdrive endpoint]
For example
The response to each of these endpoints will include a summary of the resources created, and most importantly a username/password pair for you to login as the test user. For example:
It is recommended that you carry out the tests themselves using the credentials returned by the testdrive in a private/incognito browser, so that you can log in with the test accounts provided without logging out of the test server with your main user account.
Deployment
There are no deployment considerations
Configuration changes
N/A
Scripts
N/A
Migrations
N/A
Monitoring
N/A
New Infrastructure
N/A
Continuous Integration
N/A