Week2: 기본과제+심화과제+키워드과제 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P5. 고생많으셨습니다~~!!👍 |
jumining
approved these changes
Oct 28, 2023
Comment on lines
+10
to
+12
| ){ | ||
|
|
||
| } |
There was a problem hiding this comment.
P4. 여기 줄바꿈 후 공백이 이상한 것 같은데 예쁘게 다시 수정하면 좋을 거 같아요 :)
Comment on lines
+5
to
+6
|
|
||
|
|
Comment on lines
+37
to
+79
|
|
||
|
|
||
|
|
||
| public List<MemberGetResponse> getMembers() { | ||
| return memberJpaRepository.findAll() | ||
| .stream() | ||
| .map(MemberGetResponse::of) | ||
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| @Transactional | ||
| public String create(MemberCreateRequest request){ | ||
| Member member = Member.builder() | ||
| .name(request.name()) | ||
| .nickname(request.nickname()) | ||
| .age(request.age()) | ||
| .sopt(request.sopt()) | ||
| .build(); | ||
| return memberJpaRepository.save(member).getId().toString(); | ||
| } | ||
|
|
||
| private MemberGetResponse findById(Long memberId){ | ||
| return MemberGetResponse.of(memberJpaRepository.findById(memberId) | ||
| .orElseThrow(() -> new EntityNotFoundException("존재하지 않는 회원입니다.")) | ||
| );} | ||
|
|
||
|
|
||
| @Transactional | ||
| public void updateSopt(Long memberId, MemberProfileUpdateRequest updateRequest){ | ||
| Member member = memberJpaRepository.findByIdOrThrow(memberId); | ||
| SOPT updateSopt = new SOPT(updateRequest.generation(), updateRequest.part()); | ||
| member.updateSopt(updateSopt); | ||
| } | ||
|
|
||
| @Transactional | ||
| public void deleteMember(Long memberId){ | ||
| Member member = memberJpaRepository.findByIdOrThrow(memberId); | ||
| memberJpaRepository.delete(member); | ||
| } | ||
|
|
||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
P4. 여기도 빈 줄과 줄바꿈 후 띄어쓰기 이상한 곳 수정하면 더 좋을 거 같아융
Comment on lines
+27
to
+30
| public void updateSopt(SOPT sopt){ | ||
| this.sopt = sopt; | ||
| } | ||
| } |
There was a problem hiding this comment.
P5. 제 코드에서 이 코드 빼먹어가지구 오류 났었는데 이거였군요 덕분에 발견했습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌심화 과제
멤버 생성
전체 멤버 조회
memberId로 특정 멤버 조회
(존재하지 않는 멤버 조회시 에러 메시지 출력)
멤버 수정
(generation 33 -> 34 수정)
멤버 삭제
📌키워드 과제
https://www.notion.so/2-d097ff07b7f6409d897c24f60039a72d