Week1: 기본과제(2)+심화과제+키워드과제 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unanchoi
approved these changes
Oct 12, 2023
| public class Response<T> { | ||
| private String code; | ||
| private String status; | ||
| private boolean suceess; |
|
P5. 심화 과제까지 구현하시느라 고생 많으셨습니다~! 특히 생각 과제에서 Generic에 대한 설명이 너무 잘되어있어서 정독 했습니다 :) 고생하셨어요~ |
jumining
approved these changes
Oct 25, 2023
Comment on lines
+3
to
+14
| public class HealthCheckResponse { | ||
| //private String status; | ||
| private static final String STATUS = "OK"; | ||
| public String status; | ||
|
|
||
| public HealthCheckResponse() { | ||
| //this.status = status; | ||
| this.status = STATUS; | ||
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
P4. 이 부분에 주석 처리한 코드는 삭제하지 않고 남겨둔 이유가 혹시 있을까요? 주석의 의도가 혹시 딱히 있지 않다면 지우는 것도 좋을 것 같습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 기본 과제 (seminar)
📌 심화 과제
📌 키워드 과제
https://www.notion.so/1-ab44337c027543e5b9b31764eab5b8f7?pvs=4