Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] #243 - 온보딩 MVVM + Combine 적용 #250

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

[Refactor] #243 - 온보딩 MVVM + Combine 적용 #250

wants to merge 17 commits into from

Conversation

yungu0010
Copy link
Member

@yungu0010 yungu0010 commented Mar 20, 2024 •
edited
Loading

🫧 작업한 내용

  • 온보딩 리팩토링을 진행했습니다.
  • 로그인뷰에서 불필요한 컴포넌트를 지우고 버튼 컴포넌트를 configuration으로 수정했습니다.

🔫 PR Point

  • Amplitude 로직도 뷰모델이 담당하는 게 맞다고 생각하여 저는 우선 viewDidLoadSubject를 생성하여 뷰모델에서 처리해주었습니다!
  • Auth부분도 같이해서 올리려했는데 [Refactor] 성취뷰 MVVM + Combine #241 해당 PR 네트워크 부분 반영 된 후 작업하는게 좋을 것 같아 우선 온보딩 작업부분만 먼저 올리겠습니다:)

📮 관련 이슈

@yungu0010
[Add] #243 - 온보딩 ViewModel 프로토콜 추가
e7c0197
@yungu0010
[Add] #243 - ViewModel 생성
e03ee71
@yungu0010
[Feat] #243 - LogoOnboardingView MVVM + Combine 적용
46e9041
@yungu0010
[Feat] #243 - ValueOnboardingView MVVM + Combine 적용
7d287ba
@yungu0010
[Feat] #243 - secondOnboardingView MVVM + Combine 적용
dc43e1f
@yungu0010
[Fix] #243 - guard let 구문 추가
4e18840
@yungu0010
[Feat] #243 - ThirdOnboardingView MVVM + Combine 적용
594ad44
@yungu0010
[Feat] #243 - FourthOnboardingView MVVM + Combine 적용
b6f026e
@yungu0010
[Feat] #243 - fifthOnboardingView MVVM + Combine 적용
9f6df26
@yungu0010
[Chore] #243 - 줄바꿈 변경
7c9e126
@yungu0010
[Chore] #243 - 기기대응 코드 추가
42fc6f3
@yungu0010
[Refactor] #243 - 불필요한 컴포넌트 제거 및 configuration 사용
92b2cc8
@yungu0010
[Refactor] #243 - 버튼 attribute 설정 함수 추가 및 중복 코드 함수화
88d71c7
@yungu0010
[Add] #243 - UIEvent 감지 publisher extension 추가
c0149a6
@yungu0010
[Refactor] #243 - 앰플리튜트 viewModel로 이동 & buttonTapped publisher로 변경
1fcfc2d
@yungu0010
[Del] #243 - 불필요한 코드 제거
d12321c
@yungu0010 yungu0010 self-assigned this Mar 20, 2024
jeongdung-eo
jeongdung-eo approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@jeongdung-eo jeongdung-eo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왕왕 굳굳 >< ㅎㅎㅎ 고생하셨슴동

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongdung-eo jeongdung-eo jeongdung-eo approved these changes

Assignees

@yungu0010 yungu0010

Labels
refactor 윤서
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] 온보딩 MVVM + Combine
2 participants
@yungu0010 @jeongdung-eo