Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent capitals for admin column descriptions #2282

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Aug 26, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (79be4af) 46.84% compared to head (9c47eaa) 46.84%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2282   +/-   ##
=======================================
  Coverage   46.84%   46.84%           
=======================================
  Files         249      249           
  Lines       13158    13158           
=======================================
  Hits         6164     6164           
  Misses       6994     6994           
Files Changed Coverage Δ
judge/admin/comments.py 68.29% <100.00%> (ø)
judge/admin/problem.py 54.81% <100.00%> (ø)
judge/admin/profile.py 57.50% <100.00%> (ø)
judge/admin/submission.py 40.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure Django automatically capitalizes these fields. See https://github.com/django/django/blob/11920e77959deaa65eb86ccc5d39da903fd3dd41/django/contrib/admin/templates/admin/change_list_results.html#L21. The actual database fields are not capitalized either.

@int-y1
Copy link
Contributor Author

int-y1 commented Aug 27, 2023

Pretty sure Django automatically capitalizes these fields. See https://github.com/django/django/blob/11920e77959deaa65eb86ccc5d39da903fd3dd41/django/contrib/admin/templates/admin/change_list_results.html#L21. The actual database fields are not capitalized either.

This convention also works. I didn't see anything wrong on the site.

@Ninjaclasher Ninjaclasher added this pull request to the merge queue Oct 11, 2023
Merged via the queue into DMOJ:master with commit d6dd630 Oct 11, 2023
3 checks passed
@int-y1 int-y1 deleted the desc-consistency branch October 11, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants