Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in env_checker.py bounds warning message #1636

Closed
wants to merge 4 commits into from

Conversation

Gabo-Tor
Copy link
Contributor

Description

  • Fix bug where Gym Environment Checker does not output the correct warning message when dealing with observation spaces that have different upper and different lower bounds

  • Update test_env_checker.py with more comprehensive tests

Motivation and Context

closes #1632

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

Gabo-Tor and others added 4 commits July 29, 2023 01:10
* Fix bug where Gym Environment Checker does not output the correct warning message when dealing with observation spaces that have different upper and different lower bounds

* Update test_env_checker.py with more comprehensive tests
@araffin
Copy link
Member

araffin commented Aug 1, 2023

Thanks for the PR =), unfortunately your solution only worked with 1D arrays.
As you use master branch to create the PR, I couldn't push my edits, I created a new branch here: #1638

It would be helpful if you could review it ;)

@araffin araffin closed this Aug 1, 2023
@Gabo-Tor
Copy link
Contributor Author

Gabo-Tor commented Aug 2, 2023

Thanks for the PR =), unfortunately your solution only worked with 1D arrays. As you use master branch to create the PR, I couldn't push my edits, I created a new branch here: #1638

It would be helpful if you could review it ;)

Hey there! Thanks for your feedback =) I'm sorry about missing the multiple dimensions in my solution. I'll definitely take a look at the new branch (#1638). I hope to do better on my next PR! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] in env_checker.py observation space upper and lower bounds check
2 participants